Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify interfaces #453

Merged
merged 4 commits into from
May 19, 2023
Merged

Simplify interfaces #453

merged 4 commits into from
May 19, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented May 19, 2023

The 'extension points' had grown to quite a couple: process_module, process_entry, link_libraries, finish_module, optimize_module, finish_ir and validate_module. I propose we remove the first two, as they can just be implemented as part of finish_module (I don't think there should be a semantic difference).

Added deprecations to avoid yet another version bump.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 93.84% and project coverage change: -0.20 ⚠️

Comparison is base (9351e5f) 83.29% compared to head (70384be) 83.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
- Coverage   83.29%   83.09%   -0.20%     
==========================================
  Files          23       23              
  Lines        3118     3105      -13     
==========================================
- Hits         2597     2580      -17     
- Misses        521      525       +4     
Impacted Files Coverage Δ
src/metal.jl 67.32% <66.66%> (+0.11%) ⬆️
src/irgen.jl 93.59% <90.00%> (-0.67%) ⬇️
src/gcn.jl 69.09% <100.00%> (-1.09%) ⬇️
src/interface.jl 84.21% <100.00%> (-2.31%) ⬇️
src/native.jl 100.00% <100.00%> (ø)
src/ptx.jl 93.63% <100.00%> (-0.20%) ⬇️
src/spirv.jl 91.08% <100.00%> (-0.28%) ⬇️
src/validation.jl 96.27% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit 30cd0ae into master May 19, 2023
@maleadt maleadt deleted the tb/interface_simplification branch May 19, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant