Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform library linking after deferred codegen. #458

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented May 24, 2023

I noticed a gpu_gc_pool_alloc validation error, where the allocation was only introduced in a deferred module. By moving library linking after codegen, we ensure that we'll link the necessary modules.

In addition, I now only perform the linking for the top-level compilation job, whereas we were linking it multiple times before.

cc @vchuravy, as Enzyme is a user of deferred codegen.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (5536c45) 82.58% compared to head (570d435) 82.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   82.58%   82.59%   +0.01%     
==========================================
  Files          23       23              
  Lines        3124     3126       +2     
==========================================
+ Hits         2580     2582       +2     
  Misses        544      544              
Impacted Files Coverage Δ
src/driver.jl 93.29% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit f608d82 into master May 24, 2023
@maleadt maleadt deleted the tb/deferred_libs branch May 24, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant