Perform library linking after deferred codegen. #458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a
gpu_gc_pool_alloc
validation error, where the allocation was only introduced in a deferred module. By moving library linking after codegen, we ensure that we'll link the necessary modules.In addition, I now only perform the linking for the top-level compilation job, whereas we were linking it multiple times before.
cc @vchuravy, as Enzyme is a user of deferred codegen.