Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct inlinealloc #484

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Correct inlinealloc #484

merged 2 commits into from
Jul 10, 2023

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented Jul 7, 2023

No description provided.

@maleadt
Copy link
Member

maleadt commented Jul 7, 2023

Thanks! I take it you want this backported to a version that doesn't require LLVM 6?

@wsmoses
Copy link
Contributor Author

wsmoses commented Jul 7, 2023

Yeah

@wsmoses
Copy link
Contributor Author

wsmoses commented Jul 7, 2023

I've also failed to actually make a test of this, but it does fix the bug we saw (see below):


julia> using ElectrochemicalKinetics
using GPUCompiler

julia> using GPUCompiler

# with the fix above
julia> GPUCompiler.is_inlinealloc(MarcusHushChidseyDOS{Float64})
false

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -7.79 ⚠️

Comparison is base (c0c9ab7) 82.28% compared to head (7553ebf) 74.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   82.28%   74.50%   -7.79%     
==========================================
  Files          23       23              
  Lines        3082     3051      -31     
==========================================
- Hits         2536     2273     -263     
- Misses        546      778     +232     
Impacted Files Coverage Δ
src/irgen.jl 81.31% <71.42%> (-12.08%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit ad54423 into JuliaGPU:master Jul 10, 2023
maleadt pushed a commit that referenced this pull request Jul 10, 2023
@wsmoses wsmoses deleted the inlinealloc branch July 10, 2023 17:25
@wsmoses
Copy link
Contributor Author

wsmoses commented Jul 12, 2023

@maleadt could we also get a version tag for the LLVM6 compatible branch as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants