Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dwarf_version function so targets can choose #490

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

gbaraldi
Copy link
Contributor

@gbaraldi gbaraldi commented Aug 9, 2023

It defaults to 4 like before but PTX sets it to 2 because that's what cuda supports. Following https://github.com/search?q=repo%3Allvm%2Fllvm-project%20GetDefaultDwarfVersion()&type=code

so that targets can choose their own
dwarf versions, (cuda needs v2)
@vchuravy
Copy link
Member

vchuravy commented Aug 9, 2023

I am not sure where the CUDA supports V2 came from in my head, but looks like clang sets it for v5 for AMD so this is a good change nonetheless.

Great thank you!

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -7.83% ⚠️

Comparison is base (06e6706) 81.12% compared to head (2c4e9e1) 73.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
- Coverage   81.12%   73.29%   -7.83%     
==========================================
  Files          23       23              
  Lines        3083     3048      -35     
==========================================
- Hits         2501     2234     -267     
- Misses        582      814     +232     
Files Changed Coverage Δ
src/jlgen.jl 66.55% <ø> (-3.02%) ⬇️
src/interface.jl 76.62% <100.00%> (-6.28%) ⬇️
src/ptx.jl 69.88% <100.00%> (-26.69%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vchuravy vchuravy merged commit 15f0077 into JuliaGPU:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants