Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Julia requirement to Julia 1.8 #495

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Bump minimum Julia requirement to Julia 1.8 #495

merged 4 commits into from
Aug 21, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 19, 2023

Maintaining 1.6 compatibility was becoming tedious, and we had two back-ends that required 1.8 already. With 1.10 presumably becoming the new LTS, it seems reasonable to bump the minimum requirement.

cc @vchuravy @jpsamaroo

@vchuravy
Copy link
Member

cc: @wsmoses since this will impact Enzyme as well.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -8.75% ⚠️

Comparison is base (f1924a7) 81.10% compared to head (0a51894) 72.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
- Coverage   81.10%   72.35%   -8.75%     
==========================================
  Files          23       23              
  Lines        3086     3039      -47     
==========================================
- Hits         2503     2199     -304     
- Misses        583      840     +257     
Files Changed Coverage Δ
src/interface.jl 78.20% <ø> (-4.92%) ⬇️
src/reflection_compat.jl 54.11% <ø> (+0.09%) ⬆️
src/runtime.jl 63.93% <ø> (ø)
src/validation.jl 92.25% <50.00%> (-3.90%) ⬇️
src/reflection.jl 34.37% <60.00%> (-41.31%) ⬇️
src/jlgen.jl 77.32% <80.00%> (+8.19%) ⬆️
src/irgen.jl 79.62% <81.81%> (-13.44%) ⬇️
src/optim.jl 78.80% <100.00%> (-5.00%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses
Copy link
Contributor

wsmoses commented Aug 21, 2023

Is it possible to wait to merge this until a few weeks after 1.10 is released and formally marked as the new LTS?

I want to make sure we shake out any bugs caused by folks deploying 1.10 before we drop the old LTS.

@maleadt
Copy link
Member Author

maleadt commented Aug 21, 2023

I don't think it will be formally marked LTS until we have 1.11, or at least with 1.6 it took a while. So I'd rather not postpone it that much. Instead we can just maintain a backports branch for packages that do want to keep working with 1.6 for now.

@maleadt
Copy link
Member Author

maleadt commented Aug 21, 2023

Discussed this on the GPU dev call, and it seems to make sense to move the minimum requirement to 1.8 (as an additional argument, the new scoped values support will also require it). We'll maintain a backports branch of 0.22, i.e. the current GPUCompiler version, until the new LTS has been announced some more.

@maleadt maleadt merged commit 4fe2206 into master Aug 21, 2023
@maleadt maleadt deleted the tb/julia_1.8 branch August 21, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants