Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure global variables have a safe name. #507

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 6, 2023

Because we're using the external codegen policy, Julia doesn't do this for us.

Closes JuliaLang/julia#51099

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 92.64% and project coverage change: -0.01% ⚠️

Comparison is base (c92ec6d) 83.49% compared to head (c500d95) 83.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   83.49%   83.49%   -0.01%     
==========================================
  Files          23       24       +1     
  Lines        3290     3289       -1     
==========================================
- Hits         2747     2746       -1     
  Misses        543      543              
Files Changed Coverage Δ
src/GPUCompiler.jl 100.00% <ø> (ø)
src/mangling.jl 91.93% <91.93%> (ø)
src/irgen.jl 93.38% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit d11d9ee into master Sep 6, 2023
@maleadt maleadt deleted the tb/gvar_mangling branch September 6, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant