Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ICE on non-void return types. #512

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Don't ICE on non-void return types. #512

merged 1 commit into from
Sep 12, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 12, 2023

After #510, we can encounter these.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (f28fcdc) 74.38% compared to head (7bc4248) 74.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
- Coverage   74.38%   74.35%   -0.03%     
==========================================
  Files          24       24              
  Lines        3279     3276       -3     
==========================================
- Hits         2439     2436       -3     
  Misses        840      840              
Files Changed Coverage Δ
src/irgen.jl 81.99% <ø> (-0.05%) ⬇️
src/metal.jl 67.73% <ø> (-0.06%) ⬇️
src/spirv.jl 81.69% <100.00%> (-0.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 3d8d210 into master Sep 12, 2023
@maleadt maleadt deleted the tb/ret_void branch September 12, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant