Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal: Support vector-valued intrinsics. #515

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Metal: Support vector-valued intrinsics. #515

merged 1 commit into from
Sep 14, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 14, 2023

Julia emits these on 1.10 when doing CartesianIndices operations:

julia> fill!(view(MtlArray{Float32}(undef, 2, 2), 2:2, 2:2), 0)
ERROR: Unsupported intrinsic type: LLVM.VectorType(<2 x i64>)
Stacktrace:
  [1] error(s::String)
    @ Base ./error.jl:35
  [2] lower_llvm_intrinsics!(job::GPUCompiler.CompilerJob, fun::LLVM.Function)
    @ GPUCompiler ~/Julia/pkg/GPUCompiler/src/metal.jl:893
  [3] finish_ir!(job::GPUCompiler.CompilerJob{GPUCompiler.MetalCompilerTarget}, mod::LLVM.Module, entry::LLVM.Function)
    @ GPUCompiler ~/Julia/pkg/GPUCompiler/src/metal.jl:129

@maleadt maleadt added the metal Stuff about the Apple metal back-end. label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 69.23% and project coverage change: +1.35% 🎉

Comparison is base (947507e) 82.82% compared to head (d4f513c) 84.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   82.82%   84.17%   +1.35%     
==========================================
  Files          24       24              
  Lines        3289     3292       +3     
==========================================
+ Hits         2724     2771      +47     
+ Misses        565      521      -44     
Files Changed Coverage Δ
src/metal.jl 72.57% <69.23%> (+4.84%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 5fc8d91 into master Sep 14, 2023
@maleadt maleadt deleted the tb/metal_vector branch September 14, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metal Stuff about the Apple metal back-end.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant