Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal: Emit name metadata. #518

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Metal: Emit name metadata. #518

merged 2 commits into from
Sep 19, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 19, 2023

This seems required now on macOS Sonoma, and the compiler crashes without it.

Fixes JuliaGPU/Metal.jl#201

@maleadt maleadt added the metal Stuff about the Apple metal back-end. label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: +0.21% 🎉

Comparison is base (a607fd5) 83.81% compared to head (ac9ee33) 84.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
+ Coverage   83.81%   84.03%   +0.21%     
==========================================
  Files          24       24              
  Lines        3294     3300       +6     
==========================================
+ Hits         2761     2773      +12     
+ Misses        533      527       -6     
Files Changed Coverage Δ
src/irgen.jl 93.44% <90.00%> (+0.31%) ⬆️
src/metal.jl 72.68% <100.00%> (+0.18%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 0c7b467 into master Sep 19, 2023
@maleadt maleadt deleted the tb/metal_name_md branch September 19, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metal Stuff about the Apple metal back-end.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for macOS Sonoma
1 participant