Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use CC.add_invalidation_callback! if available #529

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

aviatesk
Copy link
Contributor

@aviatesk aviatesk commented Nov 1, 2023

JuliaLang/julia#51769 allows us to not traverse backedge list by ourselves.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (1d58bff) 84.55% compared to head (2c54840) 74.29%.

❗ Current head 2c54840 differs from pull request most recent head 452580d. Consider uploading reports for the commit 452580d to get more accurate results

Files Patch % Lines
src/jlgen.jl 40.90% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #529       +/-   ##
===========================================
- Coverage   84.55%   74.29%   -10.27%     
===========================================
  Files          24       24               
  Lines        3309     3295       -14     
===========================================
- Hits         2798     2448      -350     
- Misses        511      847      +336     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JuliaLang/julia#51769 allows us to not traverse backedge list by ourselves.
@maleadt maleadt force-pushed the avi/JuliaLang/julia/51769 branch from 2c54840 to 452580d Compare January 2, 2024 09:05
@maleadt maleadt merged commit 111685f into JuliaGPU:master Jan 2, 2024
@aviatesk aviatesk deleted the avi/JuliaLang/julia/51769 branch January 3, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants