-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support internal cache #545
Conversation
0c56c7a
to
e5fe75d
Compare
e5fe75d
to
c182619
Compare
Failure on 1.11:
|
Could we also get some pretty printing back for the new cache? This is pretty sad:
|
Not really it is hard (maybe even impossible from Julia) to iterate over all cache entries. Since the entries are now a linked-list in So we would need something like @vtjnash any other ideas? |
The issue is less sinister than I feared, but I am not sure jet what went wrong,
So we ended up with the wrong mi. Edit:
Oof. Edit 2:
Edit 3: Edit 4: |
Yeah, I am not sure that pretty-printing a cache object is a sensible thing to try to enumerate |
6d338f6
to
b827ece
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #545 +/- ##
==========================================
- Coverage 82.45% 82.36% -0.09%
==========================================
Files 24 24
Lines 3322 3335 +13
==========================================
+ Hits 2739 2747 +8
- Misses 583 588 +5 ☔ View full report in Codecov by Sentry. |
b827ece
to
dd79fe0
Compare
With #555 and JuliaLang/julia#53723, this passes tests on 1.11, so we're getting close :-) |
dd79fe0
to
59d98b0
Compare
replaces #534
adapts to JuliaLang/julia#52233