Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the optimization level configurable. #577

Merged
merged 1 commit into from
May 21, 2024
Merged

Make the optimization level configurable. #577

merged 1 commit into from
May 21, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Apr 30, 2024

We also need to make sure that we have an optimization mode (probably -O1?) that only lightly optimizes, e.g. not doing loop unrolling or unswitching, but just optimizing Julia's typical IR patterns away. This is for use with shader compilers (i.e., Metal, SPIR-V, NVVM) which do their own optimization.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.74%. Comparing base (0c9292f) to head (fc36b0f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   82.86%   82.74%   -0.12%     
==========================================
  Files          24       24              
  Lines        3361     3362       +1     
==========================================
- Hits         2785     2782       -3     
- Misses        576      580       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt marked this pull request as ready for review May 21, 2024 08:42
@maleadt maleadt merged commit 104629e into master May 21, 2024
20 of 21 checks passed
@maleadt maleadt deleted the tb/opt_level branch May 21, 2024 08:42
@maleadt
Copy link
Member Author

maleadt commented Jun 18, 2024

Turns out both O0 and O1 introduce additional allocations in the generated IR. Guess we're more dependent on the alloc_otp pass than I assumed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant