Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set codegen kwargs based on toplevel setting (NFC) #600

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jul 17, 2024

This simplifies the kwarg values used in compile/codegen, and should make a little more clear what's happening and when.

It breaks the precompile.jl, but with the recent work by @vchuravy I take it we better move to an actual precompilation workload anyway?

@vchuravy
Copy link
Member

I take it we better move to an actual precompilation workload anyway?

For GPUCompiler it doesn't matter as much, but yeah we can switch to PrecompileTools.jl

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.77%. Comparing base (7143d02) to head (fdede07).

Files Patch % Lines
src/driver.jl 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   66.32%   65.77%   -0.56%     
==========================================
  Files          24       24              
  Lines        3353     3348       -5     
==========================================
- Hits         2224     2202      -22     
- Misses       1129     1146      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 28d96c1 into master Jul 17, 2024
15 checks passed
@maleadt maleadt deleted the tb/toplevel branch July 17, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants