Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metal] Fix llvm.minimum #602

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[Metal] Fix llvm.minimum #602

merged 1 commit into from
Jul 18, 2024

Conversation

tgymnich
Copy link
Member

@tgymnich tgymnich commented Jul 18, 2024

Generated functions for llvm.minimum and llvm.maximum were both called air.minimum.

fixes JuliaGPU/Metal.jl#389

@tgymnich tgymnich changed the title [metal] Fix llvm.minimum [Metal] Fix llvm.minimum Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.71%. Comparing base (28d96c1) to head (604ee9a).

Files Patch % Lines
src/metal.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
- Coverage   65.77%   65.71%   -0.06%     
==========================================
  Files          24       24              
  Lines        3348     3351       +3     
==========================================
  Hits         2202     2202              
- Misses       1146     1149       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 8ed06bf into master Jul 18, 2024
15 checks passed
@maleadt maleadt deleted the fix-metal-maximum branch July 18, 2024 06:21
@cncastillo cncastillo mentioned this pull request Aug 8, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test for min / max broadcasting issue
2 participants