Be more strict about runtime function misuse. #603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates better error messages for #596:
Incorrect number of arguments for runtime function: passing 1 argument(s) to 'void () report_exception'
)Calling an intrinsic function that clashes with an existing definition: void (i64) report_exception
). This is fairly strict, but without controlling the intrinsic definition it's possible that it doesn't match the expected behavior (i.e., what probably caused GPUCompiler emit_exception has wrong number o args #596 in the first place).