Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more strict about runtime function misuse. #603

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jul 18, 2024

Generates better error messages for #596:

  • detects the argument count mismatch (Incorrect number of arguments for runtime function: passing 1 argument(s) to 'void () report_exception')
  • in addition, refuses to generate an intrinsic call to a pre-defined function in the module (Calling an intrinsic function that clashes with an existing definition: void (i64) report_exception). This is fairly strict, but without controlling the intrinsic definition it's possible that it doesn't match the expected behavior (i.e., what probably caused GPUCompiler emit_exception has wrong number o args #596 in the first place).

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.78%. Comparing base (7143d02) to head (0e58cfd).
Report is 2 commits behind head on master.

Files Patch % Lines
src/rtlib.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
- Coverage   66.32%   62.78%   -3.55%     
==========================================
  Files          24       24              
  Lines        3353     3509     +156     
==========================================
- Hits         2224     2203      -21     
- Misses       1129     1306     +177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit a0e73b7 into master Jul 18, 2024
15 checks passed
@maleadt maleadt deleted the tb/strict_rtlib branch July 18, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant