Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling specialize_method again for typeinf_type inference #653

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented Dec 1, 2024

No description provided.

@wsmoses wsmoses requested review from vchuravy and maleadt December 1, 2024 05:54
@vchuravy vchuravy changed the title Use Cached type inference Avoid calling specialize_method again for typeinf_type inference Dec 1, 2024
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have the mi we can use it directly instead of deconstructing it.

@maleadt maleadt merged commit a94e6e2 into master Dec 2, 2024
17 of 18 checks passed
@maleadt maleadt deleted the wsmoses-patch-2 branch December 2, 2024 14:39
@maleadt
Copy link
Member

maleadt commented Dec 2, 2024

@wsmoses How come Enzyme.jl reverse CI takes over 1 hour nowadays? If expected, can you bump the timeout?

@wsmoses
Copy link
Contributor Author

wsmoses commented Dec 2, 2024

for better or worse sadly it takes ~1 hour [52 mins or so] atm. From our tests it looks to be spending most of the time on inference, which we're hoping to bring back down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants