Resolve binding MethodError directly on 1.12 #664
Conversation
|
I'd rather do the other way around; to avoid invalidations we don't really want to expose this method globally, do we? We could just rename it to |
IIUC Keno's comment in JuliaLang/julia#57290 (comment) by resolving the binding directly with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #664 +/- ##
==========================================
- Coverage 71.71% 70.21% -1.51%
==========================================
Files 24 24
Lines 3330 3330
==========================================
- Hits 2388 2338 -50
- Misses 942 992 +50 ☔ View full report in Codecov by Sentry. |
| @@ -32,6 +32,7 @@ function unsafe_function_from_type(ft::Type) | |||
| Ref{ft}()[] | |||
| end | |||
| end | |||
| global MethodError | |||
There was a problem hiding this comment.
| global MethodError | |
| function MethodError end |
imo, it's more conspicuous that this does what you want
There was a problem hiding this comment.
Actually that looks more confusing since it seems redundant to the statement below.
In every other situation I would merge a function declaration and a method declaration into one.
There was a problem hiding this comment.
Fair enough - I agree that neither syntax is really very transparent / consistent
MethodErroris pulled in implicitly and we need to disambiguate our usage herex-ref: JuliaLang/julia#57290
ought to fix the GPUCompiler issue in JuliaLang/julia#57332