add a curried version of colorview #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 60.50% 55.81% -4.69%
==========================================
Files 9 10 +1
Lines 400 473 +73
==========================================
+ Hits 242 264 +22
- Misses 158 209 +51
Continue to review full report at Codecov.
|
johnnychen94
commented
Aug 28, 2020
Comment on lines
+16
to
+19
| using ImageInTerminal | ||
| ImageInTerminal.disable_encoding() | ||
| doctest(ImageCore, manual = false) | ||
| ImageInTerminal.enable_encoding() |
There was a problem hiding this comment.
The ideal and more elegant way I have in mind to do this is:
ReferenceTests.disable_encoding(:all) do
doctest(ImageCore, manual = false)
endBut ReferenceTests is a little bit broken and fixing it requires more effort than I can put now.
@timholy I guess you're waiting for this PR to tag an ImageCore release? In this case, we could merge this version and clean up the direct test dependency of ImageInTerminal in the future. (ReferenceTests still requires ImageInTerminal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The broken jldoctest will be fixed upstream in ImageInTerminal.
closes #132