Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some more tests to arrays.jl #935

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

krishna-vasudev
Copy link
Contributor

Have added tests for different dimensions of arrays, the only type present was for 2 by 2 matrix,so i added tests for a 2 by 3 matrix.

Have added tests for different dimensions of arrays.
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #935 (0a7efb8) into master (4aa0954) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #935   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files           9        9           
  Lines        1023     1023           
=======================================
  Hits          882      882           
  Misses        141      141           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa0954...0a7efb8. Read the comment docs.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

added suggestions.

Co-authored-by: Tim Holy <[email protected]>
@timholy timholy merged commit 810480a into JuliaImages:master Jan 14, 2021
@timholy
Copy link
Member

timholy commented Jan 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants