Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use jl_value_ptr #267

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Don't use jl_value_ptr #267

merged 1 commit into from
Aug 28, 2018

Conversation

simonbyrne
Copy link
Member

Wrap immutable objects in a Ref to avoid the jl_value_ptr problems

@randy3k
Copy link
Member

randy3k commented Aug 27, 2018

Thanks

@simonbyrne
Copy link
Member Author

I'm not 100% sure how necessary this is, but probably better to be on the safe side.

Wrap objects in a Ref to avoid immutable relocation problems.
@simonbyrne
Copy link
Member Author

@yuyichao Is this handling of function callbacks correct? Or is there a better way we should be doing this?

@yuyichao
Copy link

Looks correct. A better way, if the performance of the callback is important, would be to do sth similar to JuliaMath/Cubature.jl#23 to allow specialization of the callback.

@randy3k randy3k merged commit 1cd057e into master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants