Cache registry data for PkgServer registries over Pkg invocations #2438
+49
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was already a cache in place that cached parsing of TOML files. However, many other parts of the regsitry handling (like uncompressing the version ranges) was not. In the future we want to move to keeping the registry in its tarred form which means that re-reading it will be expensive, so let's cache it instead. This takes for example the time to add Plots over and over from 234ms to 150ms.
…tuations where the original cached registry is deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was already a cache in place that cached parsing of TOML files.
However, many other parts of the registry handling (like uncompressing the version ranges) were not. In the future, we want to move to keep the registry in its tarred form which means that re-reading it will be expensive, so let's cache it instead.
This takes for example the time to add Plots over and over from 234ms to 150ms.
Ref #2435, #2431