Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.6pre Documentation for SubArray looks out of date #15931

Closed
dlfivefifty opened this issue Apr 18, 2016 · 2 comments
Closed

0.4.6pre Documentation for SubArray looks out of date #15931

dlfivefifty opened this issue Apr 18, 2016 · 2 comments
Labels
docs This change adds or pertains to documentation

Comments

@dlfivefifty
Copy link
Contributor

It states that a SubArray is defined as

type SubArray{T,N,P<:AbstractArray,I<:(ViewIndex...),LD} <: AbstractArray{T,N}
    parent::P
    indexes::I
    dims::NTuple{N,Int}
    first_index::Int   # for linear indexing and pointer
    stride1::Int       # used only for linear indexing
end

when actually it's defined as

immutable SubArray{T,N,P<:AbstractArray,I<:Tuple{Vararg{ViewIndex}},LD} <: AbstractArray{T,N}
    parent::P
    indexes::I
    dims::NTuple{N,Int}
    first_index::Int   # for linear indexing and pointer
    stride1::Int       # used only for linear indexing
end
@mbauman
Copy link
Member

mbauman commented Apr 18, 2016

Oh, yikes, I had totally forgotten about that chapter! It's woefully out of date now; there's been an even bigger refactor in #15071. In general, things are much simpler, but it'd still be worth documenting their internals. I'm not sure when I'll find time for it; if anyone else wants to take a shot at it I'd happily provide feedback.

@ivarne ivarne added the docs This change adds or pertains to documentation label Apr 19, 2016
@mbeltagy
Copy link
Contributor

mbeltagy commented Sep 20, 2016

@mbauman It continues to be out of date. Now in 0.5, we do not have sub or slice, only view. Further the explanation of the SubArray type remains dated.

kshyatt pushed a commit that referenced this issue Sep 22, 2016
Fixes #15931.

[ci skip] (ran make check-whitespace locally)
tkelman pushed a commit that referenced this issue Feb 22, 2017
Fixes #15931.

(cherry picked from commit 7c07826)
ref #18620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

No branches or pull requests

4 participants