Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override functionality for Artifacts seems to be untested #48551

Closed
KristofferC opened this issue Feb 6, 2023 · 6 comments · Fixed by #51815 or #51833
Closed

Override functionality for Artifacts seems to be untested #48551

KristofferC opened this issue Feb 6, 2023 · 6 comments · Fixed by #51815 or #51833
Labels
artifacts test This change adds or pertains to unit tests

Comments

@KristofferC
Copy link
Member

KristofferC commented Feb 6, 2023

Looking at hhttps://app.codecov.io/gh/JuliaLang/julia/blob/master/stdlib%2FArtifacts%2Fsrc%2FArtifacts.jl#L121 it seems the override functionality (Overrides.toml) is not tested. Would be good to have that done.

@KristofferC KristofferC added test This change adds or pertains to unit tests artifacts labels Feb 6, 2023
@u7581147
Copy link
Contributor

u7581147 commented Oct 12, 2023

Hi @KristofferC, I'd love to work on this issue and add tests for Artifacts.jl. Could you assign this issue to me? Thanks.

(u7581147 W-10)

@KristofferC
Copy link
Member Author

We generally don't assign issues to people to prevent "cookie licking" (https://www.redhat.com/en/blog/dont-lick-cookie). You can just start working on it anyway if you wish :)

@u7581147
Copy link
Contributor

Thanks, Kristoffer. I'll try my best to complete it but cannot guarantee anything.

@u7581147
Copy link
Contributor

u7581147 commented Oct 22, 2023

Hi @KristofferC, I added tests for the artifacts_hash() in Artifacts.jl in #51815. Am I doing it the right way?
Of course, I'm happy to add tests for other functions if it's on the right track.

@u7581147
Copy link
Contributor

Hi @KristofferC, following your comment in #51815, I added tests for load_overrides() in Artifacts.jl in #51833.

Does it do the right thing?

Thanks.

@u7581147
Copy link
Contributor

u7581147 commented Oct 24, 2023

It basically tests in three steps:

  1. Create an Overrides.toml file.
  2. Test load_overrides() using the created file.
  3. Delete any created file and directory, so that the system behaves like the test never happened.

@KristofferC KristofferC reopened this Oct 24, 2023
staticfloat pushed a commit that referenced this issue Oct 26, 2023
staticfloat pushed a commit that referenced this issue Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifacts test This change adds or pertains to unit tests
Projects
None yet
2 participants