-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override functionality for Artifacts seems to be untested #48551
Comments
Hi @KristofferC, I'd love to work on this issue and add tests for (u7581147 W-10) |
We generally don't assign issues to people to prevent "cookie licking" (https://www.redhat.com/en/blog/dont-lick-cookie). You can just start working on it anyway if you wish :) |
Thanks, Kristoffer. I'll try my best to complete it but cannot guarantee anything. |
Hi @KristofferC, I added tests for the |
Hi @KristofferC, following your comment in #51815, I added tests for Does it do the right thing? Thanks. |
It basically tests in three steps:
|
Fixes #48551 Continued from #51815 The `load_overrides()` method in `Artifacts.jl` has a large untested branch. This PR increases the test coverage for this method.  https://app.codecov.io/gh/JuliaLang/julia/blob/master/stdlib%2FArtifacts%2Fsrc%2FArtifacts.jl#L121
Fixes #48551 Continued from #51815 The `load_overrides()` method in `Artifacts.jl` has a large untested branch. This PR increases the test coverage for this method.  https://app.codecov.io/gh/JuliaLang/julia/blob/master/stdlib%2FArtifacts%2Fsrc%2FArtifacts.jl#L121
Looking at hhttps://app.codecov.io/gh/JuliaLang/julia/blob/master/stdlib%2FArtifacts%2Fsrc%2FArtifacts.jl#L121 it seems the override functionality (
Overrides.toml
) is not tested. Would be good to have that done.The text was updated successfully, but these errors were encountered: