Use Ref{T} type for BLAS calls #11402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also interested in the answer to your question. |
| ccall(($(blasfunc(fname)), libblas), Void, | ||
| (BlasInt, Ptr{$elty}, BlasInt, Ptr{$elty}, BlasInt, Ptr{$elty}), | ||
| (BlasInt, Ptr{$elty}, BlasInt, Ptr{$elty}, BlasInt, Ref{$elty}), | ||
| n, DX, incx, DY, incy, result) |
There was a problem hiding this comment.
I'm a bit surprised that not all of the existing arguments were Ptr. @viralshah
There was a problem hiding this comment.
This specific symbol is from the CBLAS API to avoid returning a complex value. In the C API, the scalar inputs are not pointers.
|
Lgtm |
|
@simonbyrne Could you rebase and merge this? |
simonbyrne
force-pushed
the
sb/blas-ref
branch
2 times, most recently
from
0aef12a to
79adca4
Compare
jakebolewski
added a commit
that referenced
this pull request
May 29, 2015
Use Ref{T} type for BLAS calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to figure out how the new
Refobject works, so I translated the ccalls inblas.jlto the new style.Is this the correct usage? In particular, for getting return values by reference:
julia/base/linalg/blas.jl
Lines 124 to 128 in 940c790
cc: @vtjnash, @jiahao, @andreasnoack