Fix printing of TypeVar with lower bound.
#16221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
| # existing `tvar_env` in order to resolve the ambiguity when printing a | ||
| # method signature. | ||
| # i.e. `foo{T,N}(::Array{T,N}, ::Array)` should be printed as | ||
| # `foo{T,N}(::Array{T,N}, ::Array{T<:Any,N<:Any})` |
There was a problem hiding this comment.
That's pretty verbose. Might be better to print Array as Array.
There was a problem hiding this comment.
I kind of agree... This comment is just describing the intent of fff2b9a so that I can figure out what is the right fix.
To get a less verbose printing, should we print Array as Array in all cases (currently it prints as Array{T,N}) or only for method signatures?
Also what about types with partially specified parameters? How should ::Vector be printed (I don't think we store the name of the TypeConstructor so we have to print it as Array{...})?
|
@JeffBezanson How about this version. |
|
Looks good. |
yuyichao
referenced
this pull request
May 6, 2016
* Also make printing of parametrized type less verbose when inside method signature or type parameter. * Add comment about the `show` method for `TypeVar` and `DataType`. * Add test for printing `TypeVar`, method signature and primary types in type parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signature or type parameter.
showmethod forTypeVarandDataType.TypeVar, method signature and primary types in typeparameter.
Fix the issue noticed in https://github.com/JuliaLang/julia/pull/15753/files/19d44318d14e4a880f3eaedf6c29f4fdf310c83a#r59119519 .