Update deprecated &x syntax in blas
#23400
Conversation
|
@nanosoldier |
|
Hm, that's weird, let's try again. @nanosoldier |
base/linalg/blas.jl
Outdated
| Ref{$relty}, Ref{$elty}, Ref{BlasInt}, Ref{$relty}, | ||
| Ref{$elty}, Ref{BlasInt}), | ||
| uplo, trans, n, k, | ||
| α, A, max(1,stride(A,2)), &β, |
There was a problem hiding this comment.
Missed & here? Nanosoldier logs complained about this so probably the reason for the benchmark failure.
|
one more time? |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
I can confirm that this actually increases the memory usage in the the |
| @@ -171,8 +171,8 @@ for (fname, elty) in ((:dcopy_,:Float64), | |||
| # SUBROUTINE DCOPY(N,DX,INCX,DY,INCY) | |||
| function blascopy!(n::Integer, DX::Union{Ptr{$elty},StridedArray{$elty}}, incx::Integer, DY::Union{Ptr{$elty},StridedArray{$elty}}, incy::Integer) | |||
| ccall((@blasfunc($fname), libblas), Void, | |||
| (Ptr{BlasInt}, Ptr{$elty}, Ptr{BlasInt}, Ptr{$elty}, Ptr{BlasInt}), | |||
There was a problem hiding this comment.
Here and in a few other places, there's no ampersand on the DX and DY. Probably still fine by proper conversions. Just wanted to point it out.
There was a problem hiding this comment.
I was going off the docs: #23307 (comment)
There was a problem hiding this comment.
I can revert this back if necessary, but it seems that they should in principle be Refs?
|
@musm Why close? |
|
@Keno mentioned he has a bot that can fix these, so I thought he could use this and lapack.jl with the bot. |
part of #6080