Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover meta nodes in replace_code_newstyle #31871

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Recover meta nodes in replace_code_newstyle #31871

merged 3 commits into from
Apr 30, 2019

Conversation

nlw0
Copy link
Contributor

@nlw0 nlw0 commented Apr 29, 2019

Fix for issue #27104. Meta nodes in ir.meta are appended to ci.code.

@nlw0 nlw0 mentioned this pull request Apr 29, 2019
Open
@nlw0
Copy link
Contributor Author

nlw0 commented Apr 29, 2019

@vchuravy can you look at these tests, please?

@vchuravy
Copy link
Member

These test look great!

vchuravy
vchuravy approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated. The commits should be squashed on merge.

@nlw0 Thank you for your contribution.

@maleadt
Copy link
Member

maleadt commented Apr 30, 2019

Backport? This has been broken for a while, is a relatively simple fix, and was used by at least CUDAnative at some point.

@vchuravy vchuravy merged commit 5168e35 into JuliaLang:master Apr 30, 2019
@nlw0
Copy link
Contributor Author

nlw0 commented Apr 30, 2019

Test failures are unrelated. The commits should be squashed on merge.

@nlw0 Thank you for your contribution.

@vchuravy Great, thanks for your support!

@maleadt maleadt mentioned this pull request May 2, 2019
Closed
KristofferC pushed a commit that referenced this pull request May 9, 2019
@nlw0 @KristofferC
Recover meta nodes in replace_code_newstyle (#31871)
a4d5aa1 
Copy meta nodes from IRCode to CodeInfo

(cherry picked from commit 5168e35)
@KristofferC KristofferC mentioned this pull request May 9, 2019
Closed
58 tasks
KristofferC pushed a commit that referenced this pull request Aug 26, 2019
@nlw0 @KristofferC
Recover meta nodes in replace_code_newstyle (#31871)
6bfb29b 
Copy meta nodes from IRCode to CodeInfo

(cherry picked from commit 5168e35)
@KristofferC KristofferC mentioned this pull request Aug 26, 2019
Merged
55 tasks
KristofferC pushed a commit that referenced this pull request Aug 26, 2019
@nlw0 @KristofferC
Recover meta nodes in replace_code_newstyle (#31871)
21dc4aa 
Copy meta nodes from IRCode to CodeInfo

(cherry picked from commit 5168e35)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@nlw0 @KristofferC
Recover meta nodes in replace_code_newstyle (#31871)
43d3581 
Copy meta nodes from IRCode to CodeInfo

(cherry picked from commit 5168e35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nlw0 @vchuravy @maleadt @KristofferC