Fix race condition in test introduced in #33119 (oops). #34142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce synchronization (via a `Channel()`) to force spawned tasks to run after the local variables are updated, showcasing the problem and the solution with `$`-interpolation.
ararslan
reviewed
Dec 19, 2019
| # Without interpolation, each spawned task sees the last value of `i` (6); | ||
| # with interpolation, each spawned task has the value of `i` at time of `@spawn`. | ||
| let | ||
| oneinterp = Vector{Any}(undef, 5) |
There was a problem hiding this comment.
Should be 4 spaces instead of 3 for this block
vtjnash
approved these changes
Dec 19, 2019
|
Ah sorry, the extra test at the bottom was incorrectly deleted via a bad
merge conflict when I was rebasing and squashing for #33119. (Shouldn't be
working remotely from this tiny laptop.)
This PR removes the duplicated tests.
Sorry, should have called that out in the description.
…On Fri, Dec 20, 2019, 1:24 AM Jameson Nash ***@***.***> wrote:
***@***.**** approved this pull request.
Looks right. Was there a merge conflict at the bottom though? Deleting
that other test doesn't seem related.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#34142?email_source=notifications&email_token=AAMCIEKKHSC2NEBZ6QUVZB3QZPGQXA5CNFSM4J45O772YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCP3BOLI#pullrequestreview-334894893>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMCIEIRSIYTWAWQACWKT33QZPGQXANCNFSM4J45O77Q>
.
|
|
Merged locally as 608567f to fixup the indent and squash the PR. |
|
Did that fix the wrongly deleted test? |
|
Thanks a bunch, @vchuravy! <3 @KristofferC, no, sorry, it wasn't wrongly deleted. It was correctly deleted, because #33119 wrongly duplicated it due to a bad merge. Added here: |
|
I appreciate the parallelism of how this was fixing two race conditions. |
|
😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce synchronization (via a
Channel()) to force spawned tasks torun after the local variables are updated, showcasing the problem and
the solution with
$-interpolation.Fixes race condition in test introduced in #33119.
Fixes #34141.