Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in(x::String, y::String) = contains(y, x) #4184

Closed
wants to merge 1 commit into from

Conversation

kmsquire
Copy link
Member

I'm not optimistic that this will fly, but I figured I would try. ;-)

If this patch isn't acceptable, we need

in(::String, ::String) = error("Use contains(x,y) for string containment")

since

julia> "not" in "knot"
false

says that "not" is not in "knot", which is clearly misleading. :-)

Other than this, to quote Stefan, I'm unreasonably happy about the infix version of "in". ;-)

@JeffBezanson
Copy link
Member

Very funny.

@StefanKarpinski
Copy link
Member

Sorry, should have waited until later in my email to comment – this is what I get for having commits sent to my inbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants