-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mitigate in-place reducedim alias bug #45821
Conversation
Documenting that aliasing is prohibited is definitely necessary. Since this PR's creation, that documentation has been added to The size equality check feels very much like a bandaid covering up for the lack of a solid aliasing story (#8087). I'm hesitant to merge a solution to the common case that leaves bugs present in more complex edge cases. |
Test failures seem relevant. |
so we should allow common bug that affects most people to keep being so while we search for a perfect solution that's gonna at least take another year or two to come by? |
fix #39385
it doesn't fix it completely, but I think this fix the most common case.
If user is doing non-trivial
view
ing and passing part of the original arrayinto the mutating function, they should check what they are doing?