[Make.inc] Define new variable PATCHELF_SET_RPATH_ARG
#48788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
building
giordano
force-pushed
the
mg/patchelf-rpath
branch
from
80425a5 to
88cbb6a
Compare
giordano
changed the title
PATCHELF_SET_RPATHPATCHELF_SET_RPATH
staticfloat
approved these changes
Feb 25, 2023
giordano
force-pushed
the
mg/patchelf-rpath
branch
from
88cbb6a to
219ef21
Compare
giordano
changed the title
PATCHELF_SET_RPATHPATCHELF_SET_RPATH_ARG
IanButterworth
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream packagers like Spack may prefer using
--add-rpathover--set-rpathand they carry patches that need to be updated for all new versions, which makes maintenance hard. With this new variable we make it easier to choose a different patchelf command without having to patch Julia's build system. CC: @haampie.I wish this to be backported to v1.9, to make packaging of the upcoming version easier. This patch only affects the build system and retains the current behaviour by default, so it should hopefully be very low-risk.