Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.9: set VERSION to 1.9.3-dev #50418

Merged
merged 2 commits into from
Jul 6, 2023
Merged

release-1.9: set VERSION to 1.9.3-dev #50418

merged 2 commits into from
Jul 6, 2023

Conversation

KristofferC
Copy link
Member

No description provided.

@KristofferC KristofferC added the release Release management and versioning. label Jul 5, 2023
@DilumAluthge
Copy link
Member

DilumAluthge commented Jul 5, 2023

To provide some context for others, we discussed this on Slack, and the purpose of this is so that people that are using e.g. 1.9-nightly in their GitHub Actions CI can see a version number (e.g. 1.9.3-DEV) that more accurately depicts what they are running.

Before this PR, someone running 1.9-nightly would just see e.g. 1.9.2 as the version number (during the period of time after 1.9.2 was tagged and before 1.9.3 was tagged), and this leads to confusion, because the user wonders whether they are actually using the correct nightly.

VERSION Outdated
@@ -1 +1 @@
1.9.2
1.9.3-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we've used the suffix pre to denote the version between patch releases. I'm not sure that really makes sense though because, for example, v"1.9.3-pre" > v"1.9.3-alpha"; so if we were to have alpha or beta versions for a patch, they'd be considered earlier than a "pre." That's actually why we use scream case on master: v"1.9.3-DEV" < v"1.9.3-alpha", as one would want. Seems like we should follow suit here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me.

@KristofferC KristofferC merged commit 6fc1be0 into release-1.9 Jul 6, 2023
@KristofferC KristofferC deleted the kc/1.9.3-dev branch July 6, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants