Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate implicit pseudo-inverses of vectors #50955

Closed
wants to merge 6 commits into from
Closed

Deprecate implicit pseudo-inverses of vectors #50955

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
974a6df
Deprecate implicit pseudo-inverses of vectors
antoine-levitt Aug 17, 2023
e75177a
Update stdlib/LinearAlgebra/src/deprecated.jl
dkarrasch Aug 30, 2023
6d534cc
fix bidiag tests
dkarrasch Aug 31, 2023
a20c7d3
modify dense and qr tests
dkarrasch Aug 31, 2023
9580830
fix tests?
dkarrasch Sep 25, 2023
c3f87f4
Merge branch 'master' into deprecate_pinv
oscardssmith Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stdlib/LinearAlgebra/src/deprecated.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ rank(A::AbstractMatrix, tol::Real) = rank(A,rtol=tol)
nullspace(A::AbstractVector, tol::Real) = nullspace(reshape(A, length(A), 1), rtol= tol)
nullspace(A::AbstractMatrix, tol::Real) = nullspace(A, rtol=tol)
pinv(A::AbstractMatrix{T}, tol::Real) where T = pinv(A, rtol=tol)

# To be removed in 2.0
Base.@deprecate /(x::Number, v::AbstractVector) x*pinv(v)
Base.@deprecate (\)(a::AbstractVector, b::AbstractArray) = pinv(a) * b
4 changes: 0 additions & 4 deletions stdlib/LinearAlgebra/src/generic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,6 @@ function (\)(A::AbstractMatrix, B::AbstractVecOrMat)
return qr(A, ColumnNorm()) \ B
end

(\)(a::AbstractVector, b::AbstractArray) = pinv(a) * b
"""
A / B

Expand Down Expand Up @@ -1155,9 +1154,6 @@ function (/)(A::AbstractVecOrMat, B::AbstractVecOrMat)
size(A,2) != size(B,2) && throw(DimensionMismatch("Both inputs should have the same number of columns"))
return copy(adjoint(adjoint(B) \ adjoint(A)))
end
# \(A::StridedMatrix,x::Number) = inv(A)*x Should be added at some point when the old elementwise version has been deprecated long enough
# /(x::Number,A::StridedMatrix) = x*inv(A)
/(x::Number, v::AbstractVector) = x*pinv(v)

cond(x::Number) = iszero(x) ? Inf : 1.0
cond(x::Number, p) = cond(x)
Expand Down