Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile.print: color Base/Core & packages. Make paths clickable #55335

Merged
merged 14 commits into from
Sep 4, 2024
Merged

Profile.print: color Base/Core & packages. Make paths clickable #55335

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a9dffca
color packages etc. in Profile.print()
IanButterworth Aug 1, 2024
538c766
use new Base string truncation functions
IanButterworth Aug 11, 2024
a67732b
use eachindex
IanButterworth Aug 11, 2024
024866f
fix some length -> textwidth
IanButterworth Aug 11, 2024
8e53b1f
StyledStrings fixes
IanButterworth Aug 11, 2024
993bb85
make file paths clickable in URI-recognizing terminal
IanButterworth Sep 2, 2024
6ae0b18
add news
IanButterworth Sep 2, 2024
bbc1a40
bold lines that have overhead
IanButterworth Sep 2, 2024
d08de78
fix
IanButterworth Sep 2, 2024
d041e9f
remove ;
IanButterworth Sep 2, 2024
7c16e91
Update Allocs.jl
IanButterworth Sep 2, 2024
15b24a8
NFC: update manifest stdlib versions
IanButterworth Sep 3, 2024
406b1a8
add styledstrings dep to stdlib manifest
IanButterworth Sep 3, 2024
cf8fa76
avoid erroring in very narrow terminals
IanButterworth Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions stdlib/Profile/src/Profile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ function print(io::IO,
end
any_nosamples = true
if format === :tree
Base.print(io, "Overhead ╎ [+additional indent] Count File:Line; Function\n")
Base.print(io, "Overhead ╎ [+additional indent] Count File:Line Function\n")
Base.print(io, "=========================================================\n")
end
if groupby == [:task, :thread]
Expand Down Expand Up @@ -990,7 +990,7 @@ function tree_format(frames::Vector{<:StackFrameTree}, level::Int, cols::Int, ma
link = editor_link(path, li.line)
styled"{link=$link:$styled_path}"
end
strs[i] = Base.annotatedstring(stroverhead, "╎", base, strcount, " ", rich_file, "; ", fname)
strs[i] = Base.annotatedstring(stroverhead, "╎", base, strcount, " ", rich_file, " ", fname)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit broke BenchmarkTools. What is the intended fix, here or in BenchmarkTools?
https://github.com/JuliaCI/BenchmarkTools.jl/actions/runs/11898803449/job/33156070523

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the ; with a space in the regex in BenchmarkTools?

if frame.overhead > 0
strs[i] = styled"{bold:$(strs[i])}"
end
Expand Down Expand Up @@ -1160,7 +1160,7 @@ function print_tree(io::IO, bt::StackFrameTree{T}, cols::Int, fmt::ProfileFormat
filenamemap = FileNameMap()
worklist = [(bt, 0, 0, AnnotatedString(""))]
if !is_subsection
Base.print(io, "Overhead ╎ [+additional indent] Count File:Line; Function\n")
Base.print(io, "Overhead ╎ [+additional indent] Count File:Line Function\n")
Base.print(io, "=========================================================\n")
end
while !isempty(worklist)
Expand Down