simplify the active_module implementation and make it a "Base feature" #55392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
active_module
is REPL instance specific but it becomes confusing sinceBase
has to try reach out for a REPL to ask it what the active module is. There is also things like a globalprevious_active_module
which shows that the REPL instance specific implementation is a best effort at best.This simplifies things by making the
active_module
a Base feature (just a global value) and then anything (including the REPL) can set that.Should fix #54888, #54780.