Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eachobs, eachbatch, kfolds, leavepout #9

Merged
merged 1 commit into from
Dec 29, 2021
Merged

add eachobs, eachbatch, kfolds, leavepout #9

merged 1 commit into from
Dec 29, 2021

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Dec 29, 2021

Changes:

  • the implementation of eachobs and eachbatch is based on generators and doesn't rely on BufferGetObs (which I didn't port)
  • eachobs doesn't rely on ObsView
  • eachobs and eachbatch have a new buffer keyword arg
  • leaveout is renamed to leavepout
  • kfolds and leavepout return generators instead of FoldView (which I didn't port).

Generally, I'm trying to go in the direction of #8 and have much less container/view types

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #9 (2e3e9dc) into main (02e1366) will increase coverage by 3.45%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   74.54%   78.00%   +3.45%     
==========================================
  Files           7        9       +2     
  Lines         165      200      +35     
==========================================
+ Hits          123      156      +33     
- Misses         42       44       +2     
Impacted Files Coverage Δ
src/dataview.jl 71.42% <ø> (ø)
src/folds.jl 92.00% <92.00%> (ø)
src/dataiterator.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e1366...2e3e9dc. Read the comment docs.

@CarloLucibello CarloLucibello mentioned this pull request Dec 29, 2021
17 tasks
@CarloLucibello CarloLucibello merged commit 9c7283e into main Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants