Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version stdlibs #1063

Merged
merged 4 commits into from
Nov 8, 2023
Merged

version stdlibs #1063

merged 4 commits into from
Nov 8, 2023

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Nov 8, 2023

this is now required for merging into the registry. I'm not 100% sure that this works with Julia 1.4 (may only work with 1.6?) but we'll see what CI says.

@stevengj stevengj changed the title version stdlibs, which requires Julia 1.6 version stdlibs Nov 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69f9157) 67.19% compared to head (863ff00) 67.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
+ Coverage   67.19%   67.35%   +0.16%     
==========================================
  Files          20       20              
  Lines        2024     2025       +1     
==========================================
+ Hits         1360     1364       +4     
+ Misses        664      661       -3     
Flag Coverage Δ
unittests 67.35% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simeonschaub
Copy link
Contributor

Ah, nice! Was just looking into this. Thanks!

@stevengj
Copy link
Member Author

stevengj commented Nov 8, 2023

Looks like the package manager is able to resolve the new dependencies on Julia 1.4 and 1.5. (It's failing on a Conda import of pyzmq, which maybe can be resolved by switching to the six package similar to JuliaPy/Conda.jl#209.)

@stevengj stevengj merged commit 3df5c48 into master Nov 8, 2023
@stevengj stevengj deleted the stevengj-patch-1 branch November 8, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants