Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: SPIRV_LLVM_Translator_jll v10.0.0+0 #12898

Merged

Conversation

jlbuild
Copy link
Contributor

@jlbuild jlbuild commented Apr 13, 2020

Autogenerated JLL package registration

UUID: 4a5d46fc-d8cf-5151-a261-86b458210efb
Repo: https://github.com/JuliaBinaryWrappers/SPIRV_LLVM_Translator_jll.jl.git
Tree: 349fa3e20d8b4eb15335a8d93a550d1a4ad607a5

Registrator tree SHA: 62db5e7577558bb878f89c5f5beccc50712c6687
@github-actions
Copy link
Contributor

Your new package pull request does not meet the following guidelines for auto-merging:

  • I was not able to load the package (i.e. import SPIRV_LLVM_Translator_jll failed). See the CI logs for details.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@vchuravy
Copy link
Member

@maleadt I expected at least this one to be able to be loaded:

libLLVM-8jl.so: cannot open shared object file: No such file or directory

Merde, we messed up the official release and didn't suffix the LLVM version there.

@maleadt
Copy link
Contributor

maleadt commented Apr 14, 2020

Looks like the 1.4.1 ship has also just sailed: JuliaLang/julia#35229
Should we drop the suffix in libLLVM_jll v8 to keep it consistent?

@KristofferC
Copy link
Member

Looks like the 1.4.1 ship has also just sailed: JuliaLang/julia#35229

I mean, if there are reasons not to release it yet, we can just delay the release). Add a comment to JuliaLang/julia#35467 in that case.

@vchuravy
Copy link
Member

vchuravy commented Apr 14, 2020 via email

@maleadt
Copy link
Contributor

maleadt commented Apr 15, 2020

OK, so they should be good to go then (assuming 1.4.1 ships a jl-suffixed libllvm). The others (LLVM 9, LLVM 10) are all going to be unloadable by the automerger's Julia version anyhow, so we can ignore its complaints.

@vchuravy vchuravy merged commit 62e8f93 into master Apr 16, 2020
@vchuravy vchuravy deleted the registrator/spirv_llvm_translator_jll/4a5d46fc/v10.0.0+0 branch April 16, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants