Delete convert(::Type{Any}, ::UpperBoundedInteger)
#316
Conversation
…dations) This method isn't necessary (it just replicates the fallback), and it triggers a lot of invalidations.
|
Ouch. Mind bumping the version? I haven't had the time to go over your comment here, but did check and see what looked like a lot of invalidation in the LV ecosystem. My plan is still to rewrite the current library when I have time, so I'm also not sure how much effort is worth spending optimizing the old library (the rewrite will be less monolithic; having pieces depend on just what they need is another motivation for splitting VectorizationBase). But low hanging fruit like this seem well worth it if they shave off compile times. Would be nice to get @ChrisRackauckas 22s -> 2.5s down to <= 2.2 so he can claim 10x faster. |
Yes, not hitting that mark definitely made the marketing harder. |
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 89.43% 89.44% +0.01%
==========================================
Files 37 37
Lines 8386 8385 -1
==========================================
Hits 7500 7500
+ Misses 886 885 -1
Continue to review full report at Codecov.
|
Head branch was pushed to by a user without write access
This method isn't necessary (it just replicates the fallback),
and it triggers ~600 invalidations.
CC @ChrisRackauckas