Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete convert(::Type{Any}, ::UpperBoundedInteger) #316

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Delete convert(::Type{Any}, ::UpperBoundedInteger) #316

merged 2 commits into from
Aug 13, 2021

Conversation

timholy
Copy link
Contributor

@timholy timholy commented Aug 13, 2021

This method isn't necessary (it just replicates the fallback),
and it triggers ~600 invalidations.

CC @ChrisRackauckas

…dations)

This method isn't necessary (it just replicates the fallback),
and it triggers a lot of invalidations.
@chriselrod chriselrod enabled auto-merge (squash) August 13, 2021 11:38
@chriselrod
Copy link
Member

chriselrod commented Aug 13, 2021

Ouch. Mind bumping the version?

I haven't had the time to go over your comment here, but did check and see what looked like a lot of invalidation in the LV ecosystem.

My plan is still to rewrite the current library when I have time, so I'm also not sure how much effort is worth spending optimizing the old library (the rewrite will be less monolithic; having pieces depend on just what they need is another motivation for splitting VectorizationBase). But low hanging fruit like this seem well worth it if they shave off compile times.

Would be nice to get @ChrisRackauckas 22s -> 2.5s down to <= 2.2 so he can claim 10x faster.

@ChrisRackauckas
Copy link
Member

Would be nice to get @ChrisRackauckas 22s -> 2.5s down to <= 2.2 so he can claim 10x faster.

Yes, not hitting that mark definitely made the marketing harder.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #316 (1a13d66) into master (6f715a9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   89.43%   89.44%   +0.01%     
==========================================
  Files          37       37              
  Lines        8386     8385       -1     
==========================================
  Hits         7500     7500              
+ Misses        886      885       -1     
Impacted Files Coverage Δ
src/reconstruct_loopset.jl 92.56% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f715a9...1a13d66. Read the comment docs.

auto-merge was automatically disabled August 13, 2021 13:09

Head branch was pushed to by a user without write access

@chriselrod chriselrod merged commit 38cf5a1 into JuliaSIMD:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants