Skip to content
This repository was archived by the owner on May 4, 2019. It is now read-only.

NullableArrays broken in v0.5 by 15071 #100

Closed
ScottPJones opened this issue Apr 2, 2016 · 5 comments
Closed

NullableArrays broken in v0.5 by 15071 #100

ScottPJones opened this issue Apr 2, 2016 · 5 comments

Comments

@ScottPJones
Copy link
Contributor

JuliaLang/julia#15071 removed the index_generate function, which is used by NullableArrays.
I've been trying to get NullableArrays working again in v0.5, and this looks like the last stumbing block.
@ScottPJones
Copy link
Contributor Author

cc: @mbauman Do you have any suggestions as to how to proceed here? Thanks!

@mbauman
Copy link
Contributor

mbauman commented Apr 2, 2016

SubArrays are much easier to work with now. No more need for generated functions. You can recompute the indices into the parent array with Base.reindex. I think the functions in subarray.jl can be simplified down to just getindex(V.parent.isnull, Base.reindex(V, V.indexes, I)...). That should give you enough to get you on the right path.

ScottPJones added a commit to ScottPJones/NullableArrays.jl that referenced this issue Apr 3, 2016
@ScottPJones
Fix issue JuliaStats#100 problems with v0.5, deprecated call() syntax
0024fc9
ScottPJones added a commit to ScottPJones/NullableArrays.jl that referenced this issue Apr 3, 2016
@ScottPJones
Fix issue JuliaStats#100 problems with v0.5, deprecated call() syntax
a2a4740
davidagold added a commit that referenced this issue Apr 11, 2016
@davidagold
Merge pull request #101 from ScottPJones/spj/fixv05
5de3aff 
Fix issue #100, make work again with v0.5
@nalimilan
Copy link
Member

@ScottPJones Can you make a PR with these changes?

@ScottPJones
Copy link
Contributor Author

@nalimilan I hadn't realized the issue wasn't automatically closed, but David Gold already merged my fixes in 8 days ago.

@nalimilan
Copy link
Member

OK, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbauman @nalimilan @ScottPJones