Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom printing of UUIDs instead of relying on Base #275

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- `test_project_extras` prints failures the same on all julia versions. In particular, 1.11 and nightly are no outliers. ([#275](https://github.com/JuliaTesting/Aqua.jl/pull/275))


## [0.8.4] - 2023-12-01

### Added
Expand Down
8 changes: 4 additions & 4 deletions src/project_extras.jl
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@ function analyze_project_extras(pkg::PkgId)
)
if !isempty(not_in_extras)
msg = "Test dependencies not in root project ($root_project_path):"
for pkgs in sort!(collect(not_in_extras); by = (pkg -> pkg.name))
msg *= "\n\t$pkgs"
for pkg in sort!(collect(not_in_extras); by = (pkg -> pkg.name))
msg *= "\n\t$(pkg.name) [$(pkg.uuid)]"
end
push!(msgs, msg)
end
if !isempty(not_in_test)
msg = "Dependencies not in test project ($test_project_path):"
for pkgs in sort!(collect(not_in_test); by = (pkg -> pkg.name))
msg *= "\n\t$pkgs"
for pkg in sort!(collect(not_in_test); by = (pkg -> pkg.name))
msg *= "\n\t$(pkg.name) [$(pkg.uuid)]"
end
push!(msgs, msg)
end
Expand Down
4 changes: 2 additions & 2 deletions test/test_project_extras.jl
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ with_sample_pkgs() do
@test any(
msg ->
occursin("Test dependencies not in root project", msg) &&
occursin("Random [", msg),
occursin("Random [9a3f8284-a2c9-5f02-9a11-845980a1fd5c]", msg),
result,
)
@test any(
msg ->
occursin("Dependencies not in test project", msg) &&
occursin("REPL [", msg),
occursin("REPL [3fa0cd96-eef1-5676-8a61-b3b8758bbffb]", msg),
result,
)
@test !any(msg -> occursin("Test [", msg), result)
Expand Down
Loading