-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CodeCov project changes informational #484
Conversation
b2d2977
to
ae56485
Compare
Updated this org setting to allow tokenless upload (tokens can still be used): https://app.codecov.io/account/gh/JuliaTime/org-upload-token |
It appears that this documentation isn't quite right as a
|
I've made a suggestion to the codecov documentation. https://docs.codecov.com/suggested-edits/679d44e8944eed0059ea758e Preview:
|
I've confirmed that both |
This reverts commit ae56485.
with: | ||
files: lcov.info | ||
token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've deleted the secret from the repository
I don't think we should see failed PR status checks when code coverage decreases. We still get good visibility into lines where coverage is missed as those still show up as annotations when viewing the diff