Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CodeCov project changes informational #484

Merged
merged 10 commits into from
Jan 31, 2025
Merged

Conversation

omus
Copy link
Member

@omus omus commented Jan 31, 2025

I don't think we should see failed PR status checks when code coverage decreases. We still get good visibility into lines where coverage is missed as those still show up as annotations when viewing the diff

@omus omus force-pushed the cv/codecov-informational branch from b2d2977 to ae56485 Compare January 31, 2025 21:08
@omus
Copy link
Member Author

omus commented Jan 31, 2025

Updated this org setting to allow tokenless upload (tokens can still be used): https://app.codecov.io/account/gh/JuliaTime/org-upload-token

@omus
Copy link
Member Author

omus commented Jan 31, 2025

It appears that this documentation isn't quite right as a .yaml extension does work:

Can I name the file .codecov.yml?

Yes, you can name the file codecov.yml or .codecov.yml. However, the file must still be located in the repository root, dev/, or .github/ directories
https://docs.codecov.com/docs/codecov-yaml#can-i-name-the-file-codecovyml

@omus
Copy link
Member Author

omus commented Jan 31, 2025

I've made a suggestion to the codecov documentation. https://docs.codecov.com/suggested-edits/679d44e8944eed0059ea758e

Preview:

Can I rename the .codecov.yml file?

Yes. Alternative file names for codecov.yml include .codecov.yml, codecov.yaml, and .codecov.yaml. However, the file must still be located in the repository root, dev/, or .github/ directories.

@omus
Copy link
Member Author

omus commented Jan 31, 2025

I've confirmed that both .codecov.yaml and codecov.yaml are supported.

with:
files: lcov.info
token: ${{ secrets.CODECOV_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've deleted the secret from the repository

@omus omus merged commit aee45b9 into master Jan 31, 2025
21 checks passed
@omus omus deleted the cv/codecov-informational branch January 31, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant