Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Danish layout #606

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

Cheesebaron
Copy link
Contributor

This PR adds a Danish layout inspired by the Swedish one, swapping some of the characters with Danish ones.

I've run the debug sample and it appears to work:
Screenshot_20240329_185617

This is my first PR in this repo, let me know if I missed anything.

Fixes #605

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

As your screen is quite wide, let me add a screenshot from a smaller device:
shot

In my testing, it's usable but maybe not on even smaller screens.

@Cheesebaron
Copy link
Contributor Author

Screenshot_20240331_013430_GitHub.jpg

This is how gboard looks as well. Just FYI.

@Julow
Copy link
Owner

Julow commented Mar 31, 2024

The 11-columns layout works for me! Did you have a look at the symbols appearing twice?

@Cheesebaron
Copy link
Contributor Author

I've adjusted the layout a bit and removed dupes. Looks like this now:

image

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! I'll merge now but of course feel free to make modifications in the future.

@Julow Julow merged commit 5e3a3f8 into Julow:master Apr 3, 2024
4 checks passed
@Cheesebaron Cheesebaron deleted the feature/danish-layout branch April 4, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Danish layout
2 participants