Add support for Android 12+ dynamic colors #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
reviewed
Jun 5, 2024
There was a problem hiding this comment.
That's awesome !
The dark theme looks like this on my side:
The side symbols looks too accented and not working together with the center symbols. Also, the "dimmer" symbols color being based on the center symbol color make it looks inconsistent.
What do you think of using the accent color (darkened) as the background of keys instead ?
|
Okay, will try that! |
|
I've changed the dark theme as I suggested earlier and it looks like this:
Many thanks for your work :) I'll merge this now, feel free to make improvements with subsequent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds three Monet themes for a light, a dark and a system dependent theme. (tested on a real device for both dark and light mode)