Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tamil layout #833

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Added tamil layout #833

merged 6 commits into from
Dec 19, 2024

Conversation

ms-jagadeeshan
Copy link
Contributor

@ms-jagadeeshan ms-jagadeeshan commented Dec 17, 2024

Added a tamil layout. The layout looks better with 0.8 scale. Is there any way to it automatically when selecting keyboard?
One more question, is there any way to add transliteration layout?
Thank you very much for creating this project, i have been using unexpected keyboard from its first release.

Signed-off-by: Jagadeeshan S <[email protected]>
@tenextractor
Copy link
Contributor

It's probably better if all dependent forms (ா etc.) are accessible directly and independent forms (அ etc.) are accessible through swipes, somewhat like InScript layout.

(Ideally there would be automatic conversion using composing text, but we don't have that in Unexpected Keyboard)

@ms-jagadeeshan
Copy link
Contributor Author

okay, this layout have all dependent and independent forms.

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! The layout looks very nice.

Appending the ':' character to a sequence result forces it to be a
string final state. This will cause a KeyValue lookup that would
normally not happen for single-character results.
This is useful to make Tamil letters smaller, even when they are the
result of a Shift.
@Julow
Copy link
Owner

Julow commented Dec 17, 2024

The layout looks better with 0.8 scale. Is there any way to it automatically when selecting keyboard?

You mean the size of the symbols ? There's several ways but I think doing that globally in KeyValue is the one that will require the less amount of maintenance. I've implemented it and pushed to your branch, what do you think ?

One more question, is there any way to add transliteration layout?

Like for the numpad for example ? No this is not possible currently. What would be yur use case ?

@ms-jagadeeshan
Copy link
Contributor Author

You mean the size of the symbols ? There's several ways but I think doing that globally in KeyValue is the one that will require the less amount of maintenance. I've implemented it and pushed to your branch, what do you think ?

yeah i meant the symbol size, now the letters look better

Like for the numpad for example ? No this is not possible currently. What would be yur use case ?

Transliteration layout i mean, generating tamil text from english , for example a becomes அ , aa becomes ஆ , ka becomes க etc

@Julow
Copy link
Owner

Julow commented Dec 19, 2024

Transliteration is not possible currently. Would you be interested in implementing it ?

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice contribution, let's merge!

I pushed to your branch to resolve the conflicts and some other changes.

@Julow Julow merged commit ae50ff2 into Julow:master Dec 19, 2024
@ms-jagadeeshan
Copy link
Contributor Author

Yeah, I am interested to implement, i will gothrough how other keyboards implement and you could also guide me with the approach and resources.

@Julow
Copy link
Owner

Julow commented Dec 19, 2024

I've started doing something similar in #594

KeyEventHandler receives all the keys that are pressed and sends the commands to the text box (eg. commitText).
This patch adds Autonormalization, which intercepts the text before it is sent (when _autonorm.typed(text) returns true) and uses Android's _ic.setComposingText to be able to change the text that was already typed into the text box.
The part that uses Normalizer2 should be removed.

Send me an email for more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants