Hindi Phonetic Keyboard Layout addition #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
reviewed
Dec 18, 2024
srcs/layouts/deva_phonetic_in.xml
Outdated
| <?xml version="1.0" encoding="UTF-8" ?> | ||
| <keyboard name="हिन्दी फोनेटिक - Hindi Phonetic" script="devanagari"> | ||
| <modmap> | ||
| <shift a="अ" b="आ" /> |
There was a problem hiding this comment.
I added these to shift.json in bd2170e. You should be able to merge the master branch and remove most of them except for these three: ड़ क़ ज्ञ (that can't work in shift.json for now)
There was a problem hiding this comment.
I have removed them. I think everything looks good. Most of the those shifted to shift.json would be useful for other future layout if any but some may be odd. Existing Hindi layouts don't use <modmap> so no need to worry I think.
characters shifted to shift.json are deleted from here
npnpatidar
commented
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hindi Phonetic keyboard is added. It has all characters needed for modern Hindi as well as Sanskrit.