Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash by sequential close, show -calls #326

Closed
amuralev opened this issue Nov 17, 2022 · 0 comments
Closed

Crash by sequential close, show -calls #326

amuralev opened this issue Nov 17, 2022 · 0 comments
Assignees
@iamsergio

Comments

@amuralev
Copy link

  1. Create minimal KDDW sample with one Dock Widget dock;
  2. Call dock->close();;
  3. Call dock-show();;
  4. Process event loop, for example explicit by QCoreApplication::processEvents();;
  5. Call any method of dock - crash...

This happens because dock is being deleted (by step 2 - 4, due to "deferred deletion" of KDDockWidgets::Frame at line)...

KDDW: 1.4, 1.5, master-branch. Diff for repro diff.txt
@iamsergio iamsergio self-assigned this Nov 17, 2022
iamsergio added a commit that referenced this issue Nov 18, 2022
@iamsergio
tests: Added a test for issue #326
5b484a7 
Currently an XFAIL
iamsergio added a commit that referenced this issue Mar 8, 2023
@iamsergio
tests: Added a test for issue #326
d8fae66 
Currently an XFAIL

(cherry-picked from commit 5b484a7)
iamsergio added a commit that referenced this issue Sep 18, 2023
@iamsergio
Print error when docking into a group being deleted
a59f843 
Not easily reproduced by the user, but can happen programatically
when doing dw->close(), followed by a dw->open().

The close() schedules a Group deletion, while dw->open() restores
it to the group. The group is then deleted on the next event loop
nd deletes the dock widgets.

For now, just printing an error, so tests fail whenever this happen.

Relates to #326.
iamsergio added a commit that referenced this issue Sep 18, 2023
@iamsergio
Add test for issue #360
1d97ada 
Issue #326 is in the way, so added a workaround.
When #326 is fixed, this test will test both code paths.
iamsergio added a commit that referenced this issue Jan 31, 2024
@iamsergio
Fix crash when calling open() right after a close()
ba72366 
Fixes #326
iamsergio added a commit that referenced this issue Jan 31, 2024
@iamsergio
Update Changelog regarding #326
1934aca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamsergio iamsergio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamsergio @amuralev