Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert in Multisplitter #336

Closed
amuralev opened this issue Jan 19, 2023 · 3 comments
Closed

Assert in Multisplitter #336

amuralev opened this issue Jan 19, 2023 · 3 comments
Assignees
@iamsergio

Comments

@amuralev
Copy link

Hi, there is repro of assert on some dokcs configurations (changes.txt, kddockwidgets_minimal_example)

docking

For branch 1.7:
image

Environment:

Windows 10 (64bit);
KDDW v1.4.0, v1.5.0, branch 1.7
@iamsergio iamsergio self-assigned this Jan 24, 2023
@iamsergio
Copy link
Contributor

will try to repro next Friday

@iamsergio
Copy link
Contributor 

$ git apply ~/Downloads/changes.txt 
error: patch failed: examples/minimal/main.cpp:39
error: examples/minimal/main.cpp: patch does not apply

Does it apply for you ? please rebase over 1.7

@amuralev
Copy link
Author

Please try changes2.txt

iamsergio added a commit that referenced this issue Jan 27, 2023
@iamsergio
tests: Add an XFAIL for issue #336
f2c3fe6
iamsergio added a commit that referenced this issue Mar 8, 2023
@iamsergio
tests: Add an XFAIL for issue #336
0f9e935 
(cherry-picked from commit f2c3fe6)
iamsergio added a commit that referenced this issue Mar 8, 2023
@iamsergio
Fix relayouting when dock widget is deleted directly
dcf3b64 
Usually, it's closed. "delete" isn't very well tested.
When it's deleted the container item becomes empty, so needs
to be resized to QSize(0,0) as well.

There's already a codepath for that but was too restrictive.
It now handles that case too.

Fixes #336

(cherry-picked from commit e7bc93a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamsergio iamsergio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamsergio @amuralev