-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: dock widget does not appear at previous place #44
Comments
"Previous Place" only supported for Main Window, as FloatingWindows are temporary. |
Hi @iamsergio , Kind Regards |
Not sure, a fix would be intrusive and create more bugs than it fixes. |
@iamsergio |
TitleBar::isFloating() was returning false, while it should have returned true. Fixed by making isFloating() simpler and dumb. isFloating() should only say if it belongs to a floating window or not. It shouldn't contain any logic about whether button should be visible or not. There's already logic elsewhere that will hide the float button in case there's nesting. Fixes issue #96 and #44
TitleBar::isFloating() was returning false, while it should have returned true. Fixed by making isFloating() simpler and dumb. isFloating() should only say if it belongs to a floating window or not. It shouldn't contain any logic about whether button should be visible or not. There's already logic elsewhere that will hide the float button in case there's nesting. Fixes issue #96 and #44 (cherry-picked from commit 0099a19)
Steps:
Result: This dock widget does not appear at previos place.
Bug only with floating windows.
Window 10, Qt 5.11.0 and Qt 5.14.1
The text was updated successfully, but these errors were encountered: