-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: cxx-qt-lib: use cxx-qt-build to build rather than cxx #837
Conversation
Unsure why this fails to link with eg
I can see those symbols in the rlib
I've tried manually linking and adjusting the output names so we don't collide, but it doesn't seem to help. What is curious is that all of the failures are templates but the CXX generated part for them 🤔 |
Figured it out, cxx-qt-build was using the module name rather than file stem for cxx::bridge like we do for cxx_qt::bridge, this caused all the bridges to use the same output C++ file names and therefore clashing. |
e4037e1
to
48a8757
Compare
Note changing a
|
33a3c6b
to
3722bc5
Compare
OK so this was just missing |
This allows for cxx-qt-lib to be optional later. Related to KDAB#319
When cxx-qt-lib is a build dependency we have a failure with a missing dll.
As this is how cxx bridges normally function, ideally we want this for cxx-qt bridges too but the macro needs to know the file name too.
3722bc5
to
eea234d
Compare
Folded into #764 |
Requires #764